-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Redirect to login page if user doesn't login #3274
Conversation
Thanks for the work! When I tested it in my local environment, I got some unexpected errors: |
It may be a bug, I will fix it in recent days. |
Thanks for this contribution. It really helps much. When backend restarted, refresh would encounter this plenty of errors. Will they disappear after this PR merged? @chouchouji |
+1 |
Does this have anything to do with it #3340 cc @huyuanfeng2018 |
I'm not sure, I wasn't focused here |
This PR does not conflict with the current PR. The two PRs focus on different points respectively and solve different problems. @czy006 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Why are the changes needed?
Close #xxx.
Brief change log
20241017-212425.mp4
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation