Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: login router fail #3350

Merged
merged 3 commits into from
Dec 3, 2024
Merged

fix: login router fail #3350

merged 3 commits into from
Dec 3, 2024

Conversation

zhangmo8
Copy link
Member

@zhangmo8 zhangmo8 commented Dec 2, 2024

Why are the changes needed?

login router fail

link #3274

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Dec 2, 2024
@github-actions github-actions bot added the module:ams-server Ams server module label Dec 3, 2024
zhoujinsong
zhoujinsong approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validate in my local environment.

@zhoujinsong zhoujinsong merged commit 4e7ab53 into apache:master Dec 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoujinsong zhoujinsong zhoujinsong approved these changes

Assignees
No one assigned
Labels
module:ams-dashboard Ams dashboard module module:ams-server Ams server module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangmo8 @zhoujinsong