From ea08b27302ef684a6a4a2a6efcc379e030d1ee97 Mon Sep 17 00:00:00 2001 From: Ashish Tiwari Date: Tue, 5 Sep 2023 16:56:31 +0530 Subject: [PATCH 1/3] fix lint error Signed-off-by: Ashish Tiwari --- apisix/plugins/proxy-cache/init.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apisix/plugins/proxy-cache/init.lua b/apisix/plugins/proxy-cache/init.lua index 4c7ce65228bd..1f49e4904a11 100644 --- a/apisix/plugins/proxy-cache/init.lua +++ b/apisix/plugins/proxy-cache/init.lua @@ -141,7 +141,7 @@ function _M.check_schema(conf) end end - -- For memory based cache, the default cache_zone cannot be used. + -- For memory based cache, the default cache_zone cannot be used. -- cache_zone will also be set as default value in case when passed empty. if conf.cache_strategy == STRATEGY_MEMORY and conf.cache_zone == DEFAULT_CACHE_ZONE then return false, "invalid or empty cache_zone for cache_strategy: "..conf.cache_strategy From 9e5068f398541bd0da0fd5e2e95208088056adda Mon Sep 17 00:00:00 2001 From: Ashish Tiwari Date: Tue, 5 Sep 2023 16:59:59 +0530 Subject: [PATCH 2/3] reindex Signed-off-by: Ashish Tiwari --- t/plugin/proxy-cache/memory.t | 1 - 1 file changed, 1 deletion(-) diff --git a/t/plugin/proxy-cache/memory.t b/t/plugin/proxy-cache/memory.t index 69c0ad30df7b..c307a4073132 100644 --- a/t/plugin/proxy-cache/memory.t +++ b/t/plugin/proxy-cache/memory.t @@ -704,4 +704,3 @@ GET /t --- response_body_like .*err: invalid or empty cache_zone for cache_strategy: memory.* --- error_code: 400 - From eee6560415c12157f38e11288bda08ae310b1dc7 Mon Sep 17 00:00:00 2001 From: Ashish Tiwari Date: Wed, 6 Sep 2023 11:17:46 +0530 Subject: [PATCH 3/3] Update t/plugin/proxy-cache/memory.t enhance test description Co-authored-by: Abhishek Choudhary --- t/plugin/proxy-cache/memory.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/plugin/proxy-cache/memory.t b/t/plugin/proxy-cache/memory.t index c307a4073132..e617f8a1b0fc 100644 --- a/t/plugin/proxy-cache/memory.t +++ b/t/plugin/proxy-cache/memory.t @@ -664,7 +664,7 @@ Cache-Control: only-if-cached -=== TEST 36: configure plugin without memory_cache zone +=== TEST 36: configure plugin without memory_cache zone for cache_strategy = memory --- config location /t { content_by_lua_block {