feat(csharp/src/Drivers/Databricks): Remove redundant CloseOperation for GetColumnsAsync #3132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddmeng-db
changed the title
toddmeng-db
commented
Jul 10, 2025
| EscapePatternWildcardsInName(ColumnName), | ||
| cancellationToken); | ||
| OperationHandle = resp.OperationHandle; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I wonder if we also want to swallow CloseOperation failures. My intuition is that it's better to know when we are calling CloseOperation incorrectly (as it adds an extra network call), so we should not.
Contributor
There was a problem hiding this comment.
yeah, should not swallow the exception here. but wondering do we see any test failures for this case, if not, we are missing some test coverage?
Contributor
Author
There was a problem hiding this comment.
It looks like our tests do not test for Dispose (which needs to be called explicitly). I will add some test suites
toddmeng-db
force-pushed
the
toddmeng-db/close-operation-2
branch
from
3c8d2b4 to
30b2f29
Compare
toddmeng-db
force-pushed
the
toddmeng-db/close-operation-2
branch
from
30b2f29 to
d04c492
Compare
jadewang-db
approved these changes
Jul 11, 2025
CurtHagenlocher
approved these changes
Jul 11, 2025
CurtHagenlocher
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous PR fixed redundant CloseOperations that were throwing errors and causing failure for dbr 11.3 and below.
GetColumnsAsync uses a seperate response handling path, which does not call GetQueryResults (where the previous fix was implemented), so this operation still fails. This PR adds a fix