Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect syntax in ArrowTypes code #453

Closed
ericphanson opened this issue Jun 6, 2023 · 2 comments · Fixed by #454
Closed

Incorrect syntax in ArrowTypes code #453

ericphanson opened this issue Jun 6, 2023 · 2 comments · Fixed by #454

Comments

@ericphanson
Copy link
Member

arrow-julia/src/ArrowTypes/src/ArrowTypes.jl

Lines 122 to 123 in 8aed969

arrowmetadata(::Type{Union{T,Missing}}) where {T} = arrowmetadata{T}
arrowmetadata(::Type{Union{T,Nothing}}) where {T} = arrowmetadata{T}

I think this should be

 arrowmetadata(::Type{Union{T,Missing}}) where {T} = arrowmetadata(T)
 arrowmetadata(::Type{Union{T,Nothing}}) where {T} = arrowmetadata(T)
@Moelf
Copy link
Contributor

Moelf commented Jun 6, 2023

We need CI coverage I guess

baumgold added a commit to baumgold/arrow-julia that referenced this issue Jun 6, 2023
@baumgold
apache#453 fix typeo introduced in apache#389
a801f7a
@baumgold baumgold mentioned this issue Jun 6, 2023
Merged
@baumgold
Copy link
Member

baumgold commented Jun 6, 2023

@ericphanson - good catch. #453 for the fix. Apologies for the inconvenience.

baumgold added a commit that referenced this issue Jun 6, 2023
@baumgold
#453 fix typeo introduced in #389 (#454)
7044e19 
I introduced this bug in #389 - my apologies.  Fixes #453.
@baumgold baumgold mentioned this issue Jun 6, 2023
Merged
baumgold added a commit that referenced this issue Jun 6, 2023
@baumgold
bump version for new release (#455)
5b6d412 
Includes the bug-fix from #453 / #454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#453 fix typeo introduced in #389 baumgold/arrow-julia
3 participants
@baumgold @Moelf @ericphanson