Introduce Arrow.ToTimestamp for performant ZonedDateTime encoding #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #95 by allowing users to wrap `ZonedDateTime` columns in `Arrow.ToTimestamp`, which will allow the writing process to skip costly check/conversion by assuming each element has the same timezone; `ToTimestamp` uses the timezone of the first element.
Codecov Report
@@ Coverage Diff @@
## main #173 +/- ##
==========================================
- Coverage 81.36% 81.33% -0.03%
==========================================
Files 25 25
Lines 3021 3027 +6
==========================================
+ Hits 2458 2462 +4
- Misses 563 565 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95 by allowing users to wrap
ZonedDateTimecolumns inArrow.ToTimestamp, which will allow the writing process to skip costlycheck/conversion by assuming each element has the same timezone;
ToTimestampuses the timezone of the first element.