Get dictionaries of children only when field.children not nothing #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdictionaries recursion only if not nothing
|
@quinnj I want to attach a test file that produces the following error |
|
Is there another way I can share the arrow test file? |
|
@okartal, so sorry for the very slow response here. The best thing would be to include the example file in your commits in this PR. Then we can just add it as a test that this is working. If you just want to commit the file, I can help actually writing a test that reads the file. |
quinnj
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #375
This PR fixes a problem in reading an Arrow IPC file generated by C# Apache.Arrow 10.0.1 where the last recursive iteration to get the dictionaries returns
nothinginstead of an empty iterable.