Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#429 fix alignment for compressed data #430

Merged
merged 1 commit into from
Apr 15, 2023
Merged

#429 fix alignment for compressed data #430

merged 1 commit into from
Apr 15, 2023

Conversation

baumgold
Copy link
Member

@baumgold baumgold commented Apr 14, 2023

Closes #429. Related to #345.

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2023

Codecov Report

Merging #430 (618fd04) into main (b3feee6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #430   +/-   ##
=======================================
  Coverage   86.95%   86.96%           
=======================================
  Files          26       26           
  Lines        3259     3261    +2     
=======================================
+ Hits         2834     2836    +2     
  Misses        425      425           
Impacted Files Coverage Δ
src/table.jl 92.85% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for doing this @baumgold! So the issue was mis-aligned pointer after we uncompressed.

@quinnj quinnj merged commit e6c44dd into apache:main Apr 15, 2023
@baumgold baumgold deleted the 429 branch April 15, 2023 10:54
@baumgold
Copy link
Member Author

@kou - Is it possible to update the tag for v2.5.1-rc1 to include this commit? If not, maybe we should instead tag v2.5.1-rc2 including this commit and start a new vote?

@kou
Copy link
Member

kou commented Apr 15, 2023

We need to cut RC2 and start a new vote.
I'll do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Failure
4 participants