Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run with 1 and 2 threads during tests #431

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Run with 1 and 2 threads during tests #431

merged 1 commit into from
Apr 23, 2023

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Apr 23, 2023

Fixes #426

@quinnj quinnj requested a review from ericphanson April 23, 2023 04:20
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2023

Codecov Report

Merging #431 (8ee4a39) into main (686ab57) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   86.96%   87.02%   +0.06%     
==========================================
  Files          26       26              
  Lines        3261     3261              
==========================================
+ Hits         2836     2838       +2     
+ Misses        425      423       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ericphanson ericphanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, and I can see it passed through: https://github.com/apache/arrow-julia/actions/runs/4776416247/jobs/8491432668?pr=431#step:6:33

it's too bad this isn't enough to reproduce #420

@quinnj quinnj merged commit e893c32 into main Apr 23, 2023
@quinnj quinnj deleted the quinnj-patch-1 branch April 23, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI doesn't test with multiple threads
4 participants