Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tables.partitions definition for Arrow.Table #443

Merged
merged 3 commits into from
May 25, 2023
Merged

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented May 24, 2023

We had this functionality w/ Arrow.Stream, but it's convenient and not that expensive to define it for Arrow.Table as well.

Fixes #293.

We had this functionality w/ `Arrow.Stream`, but it's convenient and not
that expensive to define it for `Arrow.Table` as well.

Fixes #293.
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Merging #443 (8c142ad) into main (3008e7f) will increase coverage by 3.92%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##             main     #443      +/-   ##
==========================================
+ Coverage   82.98%   86.90%   +3.92%     
==========================================
  Files          25       26       +1     
  Lines        3214     3298      +84     
==========================================
+ Hits         2667     2866     +199     
+ Misses        547      432     -115     
Impacted Files Coverage Δ
src/table.jl 92.75% <89.47%> (+3.41%) ⬆️

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@quinnj
Copy link
Member Author

quinnj commented May 24, 2023

Nightly failures are JuliaLang/julia#49777, which should be resolved soon

@quinnj quinnj requested a review from baumgold May 25, 2023 03:35
@quinnj quinnj merged commit 9385a91 into main May 25, 2023
@quinnj quinnj deleted the jq-table-partitions branch May 25, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Tables.partitions when reading "arrow file" format in addition to "stream" format
2 participants