Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup testing #462

Merged
merged 2 commits into from
Jun 12, 2023
Merged

cleanup testing #462

merged 2 commits into from
Jun 12, 2023

Conversation

baumgold
Copy link
Member

  1. Re-enable commented-out test from implement default for SubArray #456
  2. Use separate test-specific Project.toml to allow for test-specific compat (and remove compat shim)
  3. Replace testing println with testsets

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

Merging #462 (e4d2146) into main (9f1d51a) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
- Coverage   87.53%   87.50%   -0.04%     
==========================================
  Files          26       26              
  Lines        3272     3272              
==========================================
- Hits         2864     2863       -1     
- Misses        408      409       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great; thanks @baumgold!

@quinnj quinnj merged commit 5532270 into apache:main Jun 12, 2023
@baumgold baumgold deleted the test_cleanup branch June 12, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants