You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Skip redundant validation checks in RecordBatch#project (#8583)
# Which issue does this PR close?
- Closes#8591.
# Rationale for this change
RecordBatch project currently uses the validating factory function.
Since project starts from a valid RecordBatch these checks are
redundant. A small amount of work can be saved by using `new_unchecked`
instead.
A change I'm working on for DataFusion uses `RecordBatch#project` in the
inner expression evaluation loop to reduce the amount of redundant array
filtering `case` expressions need to do. While a micro optimisation,
avoiding redundant work in inner loops seems worthwhile.
# What changes are included in this PR?
- Use `new_unchecked` instead of `try_new_with_options` in
`RecordBatch#project`
# Are these changes tested?
No additional tests added.
Performance difference proven via microbenchmark
# Are there any user-facing changes?
No
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
0 commit comments