fix: regexp_match skips first match

apache · Mar 6, 2023 · 40ecf25 · 40ecf25
1 parent d016403
commit 40ecf25
Showing 1 changed file with 23 additions and 1 deletion.
diff --git a/arrow-string/src/regexp.rs b/arrow-string/src/regexp.rs
@@ -182,6 +182,9 @@ pub fn regexp_match<OffsetSize: OffsetSizeTrait>(
                 .map(|pattern| pattern.map(|pattern| pattern.to_string())),
         ),
     };
+
+    dbg!(array);
+
     array
         .iter()
         .zip(complete_pattern)
@@ -209,9 +212,14 @@ pub fn regexp_match<OffsetSize: OffsetSizeTrait>(
                     };
                     match re.captures(value) {
                         Some(caps) => {
-                            for m in caps.iter().skip(1).flatten() {
+                            let mut iter = caps.iter();
+                            if caps.len() > 1 {
+                                iter.next();
+                            }
+                            for m in iter.flatten() {
                                 list_builder.values().append_value(m.as_str());
                             }
+
                             list_builder.append(true);
                         }
                         None => list_builder.append(false),
@@ -282,6 +290,20 @@ mod tests {
         assert_eq!(&expected, result);
     }
 
+    #[test]
+    fn test_single_group_not_skip_match() {
+        let array = StringArray::from(vec![Some("foo"), Some("bar")]);
+        let pattern = GenericStringArray::<i32>::from(vec![r"foo"]);
+        let actual = regexp_match(&array, &pattern, None).unwrap();
+        let result = actual.as_any().downcast_ref::<ListArray>().unwrap();
+        let elem_builder: GenericStringBuilder<i32> = GenericStringBuilder::new();
+        let mut expected_builder = ListBuilder::new(elem_builder);
+        expected_builder.values().append_value("foo");
+        expected_builder.append(true);
+        let expected = expected_builder.finish();
+        assert_eq!(&expected, result);
+    }
+
     macro_rules! test_flag_utf8 {
         ($test_name:ident, $left:expr, $right:expr, $op:expr, $expected:expr) => {
             #[test]