Deprecate combine_option_bitmap (#4005)

apache · Apr 3, 2023 · 877a3a0 · 877a3a0
1 parent 533e983
commit 877a3a0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/arrow-data/src/bit_mask.rs b/arrow-data/src/bit_mask.rs
@@ -68,6 +68,7 @@ pub fn set_bits(
 /// Combines the null bitmaps of multiple arrays using a bitwise `and` operation.
 ///
 /// This function is useful when implementing operations on higher level arrays.
+#[deprecated(note = "Use NullBuffer::union")]
 pub fn combine_option_bitmap(
     arrays: &[&ArrayData],
     len_in_bits: usize,
@@ -247,6 +248,7 @@ mod tests {
     }
 
     #[test]
+    #[allow(deprecated)]
     fn test_combine_option_bitmap() {
         let none_bitmap = make_data_with_null_bit_buffer(8, 0, None);
         let some_bitmap =
@@ -298,6 +300,7 @@ mod tests {
     }
 
     #[test]
+    #[allow(deprecated)]
     fn test_combine_option_bitmap_with_offsets() {
         let none_bitmap = make_data_with_null_bit_buffer(8, 0, None);
         let bitmap0 =

diff --git a/arrow-string/src/concat_elements.rs b/arrow-string/src/concat_elements.rs
@@ -21,7 +21,6 @@ use arrow_array::builder::BufferBuilder;
 use arrow_array::types::ByteArrayType;
 use arrow_array::*;
 use arrow_buffer::{ArrowNativeType, NullBuffer};
-use arrow_data::bit_mask::combine_option_bitmap;
 use arrow_data::ArrayDataBuilder;
 use arrow_schema::{ArrowError, DataType};
 
@@ -125,14 +124,9 @@ pub fn concat_elements_utf8_many<Offset: OffsetSizeTrait>(
         )));
     }
 
-    let output_bitmap = combine_option_bitmap(
-        arrays
-            .iter()
-            .map(|a| a.data())
-            .collect::<Vec<_>>()
-            .as_slice(),
-        size,
-    );
+    let nulls = arrays
+        .iter()
+        .fold(None, |acc, a| NullBuffer::union(acc.as_ref(), a.nulls()));
 
     let data_values = arrays
         .iter()
@@ -170,7 +164,7 @@ pub fn concat_elements_utf8_many<Offset: OffsetSizeTrait>(
         .len(size)
         .add_buffer(output_offsets.finish())
         .add_buffer(output_values.finish())
-        .null_bit_buffer(output_bitmap);
+        .nulls(nulls);
 
     // SAFETY - offsets valid by construction
     Ok(unsafe { builder.build_unchecked() }.into())