From a14a1d3a0e68680f81acb452da86b402852e8737 Mon Sep 17 00:00:00 2001 From: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com> Date: Tue, 24 May 2022 14:00:34 +0100 Subject: [PATCH] Fix parquet benchmarks (#1723) * Fix parquet benchmarks * Format --- .github/workflows/rust.yml | 2 +- parquet/benches/arrow_reader.rs | 7 ++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index d6032e0f149c..a0456b365297 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -287,7 +287,7 @@ jobs: run: | export CARGO_HOME="/github/home/.cargo" export CARGO_TARGET_DIR="/github/home/target" - cargo check --benches --workspace + cargo check --benches --workspace --features test_common,prettyprint,async,experimental lint: name: Lint (cargo fmt) diff --git a/parquet/benches/arrow_reader.rs b/parquet/benches/arrow_reader.rs index c976ad425413..04e48baef705 100644 --- a/parquet/benches/arrow_reader.rs +++ b/parquet/benches/arrow_reader.rs @@ -130,8 +130,7 @@ where let mut pages: Vec> = Vec::new(); for _i in 0..NUM_ROW_GROUPS { let mut column_chunk_pages = VecDeque::new(); - let mem_tracker = Arc::new(parquet::memory::MemTracker::new()); - let mut dict_encoder = DictEncoder::::new(column_desc.clone(), mem_tracker); + let mut dict_encoder = DictEncoder::::new(column_desc.clone()); // add data pages for _j in 0..PAGES_PER_GROUP { // generate page @@ -239,9 +238,7 @@ fn build_dictionary_encoded_string_page_iterator( let mut pages: Vec> = Vec::new(); for _i in 0..NUM_ROW_GROUPS { let mut column_chunk_pages = VecDeque::new(); - let mem_tracker = Arc::new(parquet::memory::MemTracker::new()); - let mut dict_encoder = - DictEncoder::::new(column_desc.clone(), mem_tracker); + let mut dict_encoder = DictEncoder::::new(column_desc.clone()); // add data pages for _j in 0..PAGES_PER_GROUP { // generate page