Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preallocate buffers for FixedSizeBinary array creation #3792

Closed
maxburke opened this issue Mar 2, 2023 · 1 comment
Closed

Preallocate buffers for FixedSizeBinary array creation #3792

maxburke opened this issue Mar 2, 2023 · 1 comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@maxburke
Copy link
Contributor

maxburke commented Mar 2, 2023

When using FixedSizeBinary::try_from_iter and friends, the MutableBuffers used to hold the array data are initialized at zero, which causes a lot of time to be spent in reallocation.

(PR coming)
@maxburke maxburke added the enhancement Any new improvement worthy of a entry in the changelog label Mar 2, 2023
@maxburke maxburke mentioned this issue Mar 2, 2023
Merged
@tustvold tustvold closed this as completed Mar 6, 2023
@tustvold tustvold added the arrow Changes to the arrow crate label Mar 10, 2023
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #3793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxburke @tustvold