Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamp Unit Casts are Unchecked #3833

Closed
tustvold opened this issue Mar 9, 2023 · 1 comment · Fixed by #3840
Closed

Timestamp Unit Casts are Unchecked #3833

tustvold opened this issue Mar 9, 2023 · 1 comment · Fixed by #3840
Labels
arrow Changes to the arrow crate bug

Comments

@tustvold
Copy link
Contributor

tustvold commented Mar 9, 2023 •
edited
Loading

Describe the bug

Currently some time conversions in arrow-cast do not check for potential overflow

They should instead use unary_opt (if safe) or try_unary to return a null or error on overflow.

To Reproduce

Expected behavior

Additional context
@tustvold tustvold added the bug label Mar 9, 2023
@tustvold tustvold changed the title Timestamp Cast Conversions are Unchecked Timestamp Unit Casts are Unchecked Mar 9, 2023
@Weijun-H Weijun-H mentioned this issue Mar 10, 2023
Merged
@tustvold tustvold added the arrow Changes to the arrow crate label Mar 10, 2023
@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'arrow'} from #3840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: timestamp overflow check Weijun-H/arrow-rs
1 participant
@tustvold