-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minute
and second
temporal kernels do not respect timezone
#500
Comments
I would like to work on this. split in two parts
sounds okay ? |
makes sense to me. I have done this recently in arrow2 around here |
@sum12 this also sounds reasonable to me. As you have probably seen the spec for what can be in the timezone string is here: https://github.com/apache/arrow/blob/master/format/Schema.fbs#L341-L351 and I believe your proposal in #500 (comment) is consistent with that Regarding |
Thanks for the feedback. @alamb, created a PR for now, does not really follow the proposal. I have tried to reuse the parsing capabilities of the chrono itself to parse the timezone. Not sure if it is okay to go down that route. Although happy to back to proposal if the PR is not going in the correct direction. |
Describe the bug
As pointed out by @jorgecarleitao https://github.com/apache/arrow-rs/pull/493/files#r656987963 the
minute
andsecond
temporal kernels do not respect timezoneTo Reproduce
Extract seconds from a timestamp column that has an associated timezone (aka is not
None
orUtc
) will always be interpreted as a timestamp in UTC rather than the specified timezone.Expected behavior
Seconds to be interpreted in terms of the the timezone or raise an error about not being supported
The text was updated successfully, but these errors were encountered: