Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayData::slice() does not work for nested types such as StructArray #554

Closed
alamb opened this issue Jul 14, 2021 · 2 comments · Fixed by #389
Closed

ArrayData::slice() does not work for nested types such as StructArray #554

alamb opened this issue Jul 14, 2021 · 2 comments · Fixed by #389
Labels

Comments

@alamb
Copy link
Contributor

alamb commented Jul 14, 2021

Describe the bug
ArrayData::slice() does not work for nested types, because only the ArrayData::buffers are updated with the new offset and length. This has caused a lot of issues in the past.

This blocks us from being able to implement RecordBatch::slice(), and has led to creating #381 to sidestep this issue.

@nevi-me
Copy link
Contributor

nevi-me commented Jul 14, 2021

Thanks for this @alamb, I hadn't noticed that not linking PRs to existing issues affects the changelog.

@alamb
Copy link
Contributor Author

alamb commented Jul 14, 2021

Thanks for this @alamb, I hadn't noticed that not linking PRs to existing issues affects the changelog.

Yes @nevi-me I don't fully understand the intricacies of the changelog generator that @jorgecarleitao found but it seems to be mostly derived from issues (rather than PRs) 🤷 I figured I will keep honing the process in future releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants