Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lint to automatically check for unused dependencies #6796

Open
alamb opened this issue Nov 25, 2024 · 2 comments · May be fixed by #6804
Open

Add a lint to automatically check for unused dependencies #6796

alamb opened this issue Nov 25, 2024 · 2 comments · May be fixed by #6804

Comments

@alamb
Copy link
Contributor

alamb commented Nov 25, 2024

          Perhaps we could enable a lint to test for this?

Originally posted by @tustvold in #6792 (review)

@findepi
Copy link
Member

findepi commented Nov 25, 2024

for context, in the past i tried using cargo machete, but was disappointed by false positives (maybe because i run it on a complex project). For #6792 i used RustRover's builtin capabilities. But even then I had to solve false positives manually. In apache/datafusion#13541 there was also one false positive (apparently due to an imperfectly implemented macro / limitation in RR -- depending on how we look at it)

I wish I knew how to make this automated.

@tustvold
Copy link
Contributor

unused_crate_dependencies is a lint that can be enabled at the workspace level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants