Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parquet benchmarks #1723

Merged
merged 2 commits into from
May 24, 2022
Merged

Fix parquet benchmarks #1723

merged 2 commits into from
May 24, 2022

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Part of #1474

Rationale for this change

#1683 broke the benchmarks and this was not caught by CI due to missing features

What changes are included in this PR?

Fixes compilation and adds the features to CI. Unfortunately we cannot use --all-features as the simd feature only works on nightly...

Are there any user-facing changes?

No

@github-actions github-actions bot added the parquet Changes to the parquet crate label May 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1723 (3e2bcc7) into master (7b164a0) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1723      +/-   ##
==========================================
- Coverage   83.32%   83.30%   -0.02%     
==========================================
  Files         195      195              
  Lines       56044    55978      -66     
==========================================
- Hits        46698    46634      -64     
+ Misses       9346     9344       -2     
Impacted Files Coverage Δ
arrow/src/array/data.rs 83.65% <0.00%> (-0.80%) ⬇️
arrow/src/compute/util.rs 98.90% <0.00%> (-0.01%) ⬇️
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (ø)
arrow/src/array/transform/mod.rs 86.85% <0.00%> (+0.05%) ⬆️
parquet/src/encodings/encoding.rs 93.65% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b164a0...3e2bcc7. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tustvold

@alamb alamb merged commit a14a1d3 into apache:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants