-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor: make Parquet CLI input args consistent #3786
Conversation
What do you think of unifying in the opposite direction, i.e. making the other tools take positional arguments? |
Positional arguments may not be well suited for tools like parquet-fromcsv and parquet-rewrite, which have too many arguments (and many file names). But for the tools that only require one file to read, I think getting rid of "-f" makes it handier. For those tools, we can make filename positional and leave other options there. e.g.
|
I think it is fine for the more complex tools to have a different argument pattern from those that take a single input file |
I think the pyspark integration test needs to be updated |
Thank you 👍 |
Benchmark runs are scheduled for baseline = 40e2874 and contender = e52574c. e52574c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3785.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?