Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: make Parquet CLI input args consistent #3786

Merged
merged 5 commits into from
Mar 3, 2023

Conversation

XinyuZeng
Copy link
Contributor

Which issue does this PR close?

Closes #3785.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Mar 2, 2023
@tustvold
Copy link
Contributor

tustvold commented Mar 2, 2023

What do you think of unifying in the opposite direction, i.e. making the other tools take positional arguments?

@XinyuZeng
Copy link
Contributor Author

Positional arguments may not be well suited for tools like parquet-fromcsv and parquet-rewrite, which have too many arguments (and many file names). But for the tools that only require one file to read, I think getting rid of "-f" makes it handier. For those tools, we can make filename positional and leave other options there.

e.g.

parquet-read [OPTIONS] <FILE_NAME>

@tustvold
Copy link
Contributor

tustvold commented Mar 2, 2023

I think it is fine for the more complex tools to have a different argument pattern from those that take a single input file

@tustvold
Copy link
Contributor

tustvold commented Mar 2, 2023

I think the pyspark integration test needs to be updated

@tustvold
Copy link
Contributor

tustvold commented Mar 3, 2023

Thank you 👍

@tustvold tustvold merged commit e52574c into apache:master Mar 3, 2023
@tustvold tustvold added the api-change Changes to the arrow API label Mar 3, 2023
@ursabot
Copy link

ursabot commented Mar 3, 2023

Benchmark runs are scheduled for baseline = 40e2874 and contender = e52574c. e52574c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Parquet CLI args consistent
3 participants