Preallocate buffers for FixedSizeBinary array creation #3793
Conversation
| let mut buffer = MutableBuffer::from_len_zeroed(0); | ||
|
|
||
| let iter_size_hint = iter.size_hint().0; | ||
| let mut null_buf = MutableBuffer::from_len_zeroed((iter_size_hint + 7) / 8); |
There was a problem hiding this comment.
I would perhaps expect to see MutableBuffer::new here - https://docs.rs/arrow-buffer/latest/arrow_buffer/struct.MutableBuffer.html#method.new?
| let mut null_buf = MutableBuffer::from_len_zeroed(0); | ||
|
|
||
| let iter_size_hint = iter.size_hint().0; | ||
| let mut null_buf = MutableBuffer::from_len_zeroed((iter_size_hint + 7) / 8); |
There was a problem hiding this comment.
Can we use bit_util::ceil here instead
|
Benchmark runs are scheduled for baseline = f8abb04 and contender = b9fcd7f. b9fcd7f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Closes issue #3792