fix: regexp_match skips first match #3807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
reviewed
Mar 6, 2023
arrow-string/src/regexp.rs
Outdated
Comment on lines
185
to
187
|
|
||
| dbg!(array); | ||
|
|
There was a problem hiding this comment.
Suggested change
| dbg!(array); |
|
I've left a comment on the ticket - #3803 (comment) I'm not sure this is actually a bug |
Weijun-H
force-pushed
the
fix-regexp_match
branch
from
40ecf25 to
ad1a634
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3803
Rationale for this change
The
regexp_matchfunction currently only ignores the first match when there are multiple group matches.What changes are included in this PR?
Are there any user-facing changes?