feat: add take for MapArray #3925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
commented
Mar 24, 2023
arrow-array/src/array/map_array.rs
Outdated
Comment on lines
276
to
287
| let old_data = value.to_data(); | ||
| let array_data = unsafe { | ||
| ArrayData::new_unchecked( | ||
| DataType::Map(field.clone(), false), | ||
| old_data.len(), | ||
| Some(old_data.null_count()), | ||
| old_data.nulls().map(|nulls|nulls.buffer().clone()), | ||
| old_data.offset(), | ||
| old_data.buffers().to_vec(), | ||
| old_data.child_data().to_vec(), | ||
| ) | ||
| }; |
There was a problem hiding this comment.
Is there a better way to create a copy of ArrayData that's the same except for the type?
There was a problem hiding this comment.
Thanks, that's much better!
tustvold
reviewed
Mar 24, 2023
arrow-array/src/array/map_array.rs
Outdated
| @@ -251,6 +251,69 @@ impl std::fmt::Debug for MapArray { | |||
| } | |||
| } | |||
|
|
|||
| impl TryFrom<&ListArray> for MapArray { | |||
There was a problem hiding this comment.
Suggested change
| impl TryFrom<&ListArray> for MapArray { | |
| impl TryFrom<ListArray> for MapArray { |
To be consistent with other array conversions, and to make the clone explicit if necessary
tustvold
reviewed
Mar 24, 2023
arrow-array/src/array/map_array.rs
Outdated
| let old_data = value.to_data(); | ||
| let array_data = unsafe { | ||
| ArrayData::new_unchecked( | ||
| DataType::Map(field.clone(), false), |
There was a problem hiding this comment.
This data type inference is potentially problematic, as it loses part
There was a problem hiding this comment.
I'm not sure what you meant here, but I deleted this implementation so not sure it's relevant anyways.
richox
pushed a commit
to richox/arrow-rs
that referenced
this pull request
Apr 7, 2023
* feat: add take for MapArray * refactor: use into_builder
richox
pushed a commit
to richox/arrow-rs
that referenced
this pull request
Apr 7, 2023
* feat: add take for MapArray * refactor: use into_builder
richox
pushed a commit
to richox/arrow-rs
that referenced
this pull request
Apr 7, 2023
* feat: add take for MapArray * refactor: use into_builder
richox
pushed a commit
to richox/arrow-rs
that referenced
this pull request
Apr 7, 2023
* feat: add take for MapArray * refactor: use into_builder
richox
pushed a commit
to richox/arrow-rs
that referenced
this pull request
Apr 7, 2023
* feat: add take for MapArray * refactor: use into_builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3875
Rationale for this change
This seems to be one of the only array types that isn't supported by this function.
What changes are included in this PR?
Adds an easy conversion between
MapArrayandListArray, which allows us to reuse kernels that supportListArray.Are there any user-facing changes?
No breaking changes.