Add PrimitiveArray::try_new (#3879) #4067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
primitive-array-try-new
branch
from
d74b35e to
b50bc34
Compare
tustvold
force-pushed
the
primitive-array-try-new
branch
from
b50bc34 to
1f869af
Compare
alamb
reviewed
Apr 14, 2023
| if let Some(n) = nulls.as_ref() { | ||
| assert_eq!(values.len(), n.len()); | ||
| if n.len() != values.len() { |
There was a problem hiding this comment.
Is this redundant with checks from ArrayData. Is it inevitable that we'll have redundancy between the checks?
I am thinking of https://docs.rs/arrow/latest/arrow/array/struct.ArrayData.html#method.validate and friends
There was a problem hiding this comment.
In the long-run we may be able to share code, but as the types of the buffers and the already validated constraints are different, I think some redundancy is inevitable. Fortunately most of this logic is fairly straightforward
viirya
reviewed
Apr 15, 2023
| assert_eq!(values.len(), n.len()); | ||
| if n.len() != values.len() { | ||
| return Err(ArrowError::InvalidArgumentError(format!( | ||
| "Incorrect number of nulls for PrimitiveArray, expected {} got {}", |
There was a problem hiding this comment.
number of nulls could be confused.
Suggested change
| "Incorrect number of nulls for PrimitiveArray, expected {} got {}", | |
| "Incorrect length of null buffer for PrimitiveArray, expected {} got {}", |
viirya
approved these changes
Apr 15, 2023
alamb
approved these changes
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3879
Rationale for this change
Some codebases may want to avoid panicking, and whilst for PrimitiveArray the necessary checks are pretty inconsequential, for consistency we should provide a try_new method for all arrays.
What changes are included in this PR?
Are there any user-facing changes?