Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove clippy unnecessary wraps suppresions in cast kernel #449

Merged
merged 1 commit into from
Jun 12, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Jun 11, 2021

Which issue does this PR close?

Closes #.

Rationale for this change

This clippy rule is moved to pedantic phase so no longer will raise a warning by default thus we can remove the suppressions

What changes are included in this PR?

Are there any user-facing changes?

@jimexist jimexist changed the title remove clippy unnecessary wraps remove clippy unnecessary wraps in cast kernel Jun 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.65%. Comparing base (0c00776) to head (e1c2dc4).
Report is 2920 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
- Coverage   82.71%   82.65%   -0.06%     
==========================================
  Files         163      164       +1     
  Lines       44795    45468     +673     
==========================================
+ Hits        37051    37581     +530     
- Misses       7744     7887     +143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimexist jimexist marked this pull request as ready for review June 11, 2021 14:34
@jimexist jimexist closed this Jun 11, 2021
@jimexist jimexist reopened this Jun 11, 2021
@jimexist jimexist changed the title remove clippy unnecessary wraps in cast kernel remove clippy unnecessary wraps suppresions in cast kernel Jun 11, 2021
@Dandandan Dandandan merged commit dc5507a into apache:master Jun 12, 2021
@Dandandan
Copy link
Contributor

Thanks @jimexist

@jimexist jimexist deleted the remove-unnecessary-wrap-in-cast branch June 12, 2021 13:21
alamb pushed a commit that referenced this pull request Jun 22, 2021
alamb added a commit that referenced this pull request Jun 23, 2021
Co-authored-by: Jiayu Liu <Jimexist@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants