Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FixedSizeListArray::new in FixedSizeListBuilder #5612

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Use FixedSizeListArray::new in FixedSizeListBuilder #5612

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
999c746
Use FixedSizeListArray::new in FixedSizeListBuilder
tustvold Apr 9, 2024
bfc0c6b
Fix handling of entirely null zero-sized list array (#5614)
tustvold Apr 9, 2024
7fa6e17
Fix
tustvold Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion arrow-array/src/array/fixed_size_list_array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ mod tests {
);

let list = FixedSizeListArray::new(field.clone(), 0, values.clone(), None);
assert_eq!(list.len(), 6);
assert_eq!(list.len(), 0);
Copy link
Contributor Author

@tustvold tustvold Apr 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically incorrect, in a FixedSizeListArray with size 0, the length of the values has no bearing on the length of the array

I've created #5615 to track that it isn't possible to create a non-empty, non-nullable FixedSizeListArray with size 0.


let nulls = NullBuffer::new_null(2);
let err = FixedSizeListArray::try_new(field, 2, values.clone(), Some(nulls)).unwrap_err();
Expand Down
Loading