Add an API to append view by u128 in for view_builder #6291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kev1n8
changed the title
tustvold
reviewed
Aug 23, 2024
| /// must be within the bounds of the block | ||
| /// (3) The data in the block must be valid type `T` | ||
| /// (4) The view must be not null | ||
| pub unsafe fn append_view_u128_unchecked(&mut self, view: u128) { |
There was a problem hiding this comment.
If appending raw u128 what is the benefit of using the builder at all, as opposed to just using a Vec<u128> directly? Is the intended use-case to intermix this method with some of the others?
There was a problem hiding this comment.
That's a good point. However, I believe that StringViewArray does not currently provide a From<Vec<u128>> trait directly. The related PR is intended to manually modify views to obtain the substr_view, which can then be added to the builder. Additionally, since the core implementation of StringView is based on the builder pattern, it seemed natural to me to use it.
There was a problem hiding this comment.
There was a problem hiding this comment.
I see. That's useful. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
The idea is to make the builder a way to append a view by a given u128 (unchecked). Check out this comment.
What changes are included in this PR?
A function is added to the view builder.
Are there any user-facing changes?
no