From 77fbfff75b185447f7ec520317d383ce89c490ef Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Mon, 18 Oct 2021 06:30:19 -0400 Subject: [PATCH 1/3] Delete temp file from docs --- parquet/src/arrow/mod.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/parquet/src/arrow/mod.rs b/parquet/src/arrow/mod.rs index d2a1daa067f1..bab84639d71d 100644 --- a/parquet/src/arrow/mod.rs +++ b/parquet/src/arrow/mod.rs @@ -53,7 +53,7 @@ //! } //! writer.close().unwrap(); //! ``` - +//! //! `WriterProperties` can be used to set Parquet file options //! ```rust //! use parquet::file::properties::WriterProperties; @@ -64,6 +64,7 @@ //! let props = WriterProperties::builder() //! .set_compression(Compression::SNAPPY) //! .build(); +//! # std::fs::remove_file(&file).unwrap(); //! ``` //! //! # Example of reading parquet file into arrow record batch @@ -116,6 +117,7 @@ //! println!("End of file!"); //! } //!} +//! # std::fs::remove_file(&file).unwrap(); //! ``` pub mod array_reader; From 72ff56ef5f6c4a577142613df4152a8059863bf0 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Mon, 18 Oct 2021 06:36:20 -0400 Subject: [PATCH 2/3] fix --- parquet/src/arrow/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/parquet/src/arrow/mod.rs b/parquet/src/arrow/mod.rs index bab84639d71d..d5b2479b7761 100644 --- a/parquet/src/arrow/mod.rs +++ b/parquet/src/arrow/mod.rs @@ -64,7 +64,7 @@ //! let props = WriterProperties::builder() //! .set_compression(Compression::SNAPPY) //! .build(); -//! # std::fs::remove_file(&file).unwrap(); +//! # std::fs::remove_file("data.parquet").unwrap(); //! ``` //! //! # Example of reading parquet file into arrow record batch @@ -117,7 +117,7 @@ //! println!("End of file!"); //! } //!} -//! # std::fs::remove_file(&file).unwrap(); +//! # std::fs::remove_file("data.parquet").unwrap(); //! ``` pub mod array_reader; From c363beab0a5d22e3b8128efb95457604d9cd6502 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Mon, 18 Oct 2021 14:44:33 -0400 Subject: [PATCH 3/3] Use gitignore instead --- .gitignore | 2 ++ parquet/src/arrow/mod.rs | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index e8d9955b6488..8c158a246328 100644 --- a/.gitignore +++ b/.gitignore @@ -6,3 +6,5 @@ rusty-tags.vi .idea/ .vscode venv/* +# created by doctests +parquet/data.parquet \ No newline at end of file diff --git a/parquet/src/arrow/mod.rs b/parquet/src/arrow/mod.rs index d5b2479b7761..227bbdcd27a0 100644 --- a/parquet/src/arrow/mod.rs +++ b/parquet/src/arrow/mod.rs @@ -64,7 +64,6 @@ //! let props = WriterProperties::builder() //! .set_compression(Compression::SNAPPY) //! .build(); -//! # std::fs::remove_file("data.parquet").unwrap(); //! ``` //! //! # Example of reading parquet file into arrow record batch @@ -117,7 +116,6 @@ //! println!("End of file!"); //! } //!} -//! # std::fs::remove_file("data.parquet").unwrap(); //! ``` pub mod array_reader;