You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test for TypedColumnReader::Skip with repeated values to make it clear that we are skipping values and not records.
Also, add some comments to the existing test for Skip of non-repeated values.
@emkornfield can you merge this pull request? You already reviewed it, but the pull request was not against the master. This includes some commits that are already checked in. I am not sure how to remove them. You can try looking at the changes from "Merge pull request #1 from fatemehp/skip_test".
kou
changed the title
PARQUET-2179: [parquet-cpp] Add a test for skipping repeated fields
PARQUET-2179: [C++][Parquet] Add a test for skipping repeated fields
Oct 10, 2022
@fatemehp it looks like this merged commits from the SkipRecords with the additional tests for Skip method that only skips values, could you remove some of the commits?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kou
changed the title
Add a test for
TypedColumnReader::Skipwith repeated values to make it clear that we are skipping values and not records.Also, add some comments to the existing test for Skip of non-repeated values.