-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-38624: [C++] Fix: add TestingEqualOptions for gtest functions. #38642
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General LGTM!
Also cc @bkietz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please fix the formatting
done @bkietz |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0e52d30. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 19 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…s. (apache#38642) ### Rationale for this change some other interfaces lack equal options, suck as nan equal, so we add TestingEqualOptions for each function and add some testing. ### What changes are included in this PR? gtest_util related. ### Are these changes tested? gtest_util.cc ### Are there any user-facing changes? yes. * Closes: apache#38624 Authored-by: light-city <455954986@qq.com> Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
Rationale for this change
some other interfaces lack equal options, suck as nan equal, so we add TestingEqualOptions for each function and add some testing.
What changes are included in this PR?
gtest_util related.
Are these changes tested?
gtest_util.cc
Are there any user-facing changes?
yes.