Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-38624: [C++] Fix: add TestingEqualOptions for gtest functions. #38642

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

Light-City
Copy link
Contributor

@Light-City Light-City commented Nov 9, 2023

Rationale for this change

some other interfaces lack equal options, suck as nan equal, so we add TestingEqualOptions for each function and add some testing.

What changes are included in this PR?

gtest_util related.

Are these changes tested?

gtest_util.cc

Are there any user-facing changes?

yes.

Copy link

github-actions bot commented Nov 9, 2023

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@Light-City Light-City changed the title [GH-38624][C++] Fix: add TestingEqualOptions for table and batches. [GH-38624][C++] Fix: add TestingEqualOptions for gtest functions. Nov 9, 2023
@Light-City Light-City changed the title [GH-38624][C++] Fix: add TestingEqualOptions for gtest functions. GH-38624 [C++] Fix: add TestingEqualOptions for gtest functions. Nov 9, 2023
Copy link

github-actions bot commented Nov 9, 2023

⚠️ GitHub issue #38624 has been automatically assigned in GitHub to PR creator.

@Light-City Light-City changed the title GH-38624 [C++] Fix: add TestingEqualOptions for gtest functions. GH-38624: [C++] Fix: add TestingEqualOptions for gtest functions. Nov 9, 2023
@Light-City
Copy link
Contributor Author

@mapleFU @js8544 here, add TestingEqualOptions to fix previous issue

Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General LGTM!

Also cc @bkietz

cpp/src/arrow/testing/gtest_util.h Show resolved Hide resolved
cpp/src/arrow/testing/gtest_util.h Show resolved Hide resolved
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Nov 10, 2023
@mapleFU mapleFU requested a review from bkietz November 14, 2023 05:56
Copy link
Member

@bkietz bkietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Nov 15, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Nov 15, 2023
@Light-City
Copy link
Contributor Author

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Nov 15, 2023
@bkietz bkietz merged commit 0e52d30 into apache:main Nov 15, 2023
32 of 35 checks passed
@bkietz bkietz removed the awaiting merge Awaiting merge label Nov 15, 2023
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0e52d30.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 19 possible false positives for unstable benchmarks that are known to sometimes produce them.

dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…s. (apache#38642)

### Rationale for this change

some other interfaces lack equal options, suck as nan equal, so we add TestingEqualOptions for each function and add some testing.

### What changes are included in this PR?

gtest_util related.

### Are these changes tested?

gtest_util.cc

### Are there any user-facing changes?
yes.
* Closes: apache#38624

Authored-by: light-city <455954986@qq.com>
Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C++] During unit testing, the float array contains nan equality judgment
3 participants