diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 30f1eef0300..ad8aab4b229 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -325,6 +325,7 @@ repos: ?^ci/scripts/install_numpy\.sh$| ?^ci/scripts/install_pandas\.sh$| ?^ci/scripts/install_python\.sh$| + ?^ci/scripts/install_sccache\.sh$| ?^ci/scripts/install_spark\.sh$| ?^ci/scripts/install_vcpkg\.sh$| ?^ci/scripts/integration_arrow_build\.sh$| diff --git a/ci/scripts/install_sccache.sh b/ci/scripts/install_sccache.sh index 136f39b3ae2..c571625a3b3 100755 --- a/ci/scripts/install_sccache.sh +++ b/ci/scripts/install_sccache.sh @@ -19,7 +19,7 @@ set -e -if [ "$#" -lt 1 -o "$#" -gt 3 ]; then +if [ "$#" -lt 2 ] || [ "$#" -gt 3 ]; then echo "Usage: $0 " echo "Will default to version=0.3.0 " exit 1 @@ -39,30 +39,30 @@ SCCACHE_URL="https://github.com/mozilla/sccache/releases/download/v$VERSION/scca SCCACHE_ARCHIVE=sccache.tar.gz # Download archive and checksum -curl -L $SCCACHE_URL --output $SCCACHE_ARCHIVE -curl -L $SCCACHE_URL.sha256 --output $SCCACHE_ARCHIVE.sha256 +curl -L "$SCCACHE_URL" --output $SCCACHE_ARCHIVE +curl -L "${SCCACHE_URL}.sha256" --output $SCCACHE_ARCHIVE.sha256 echo " $SCCACHE_ARCHIVE" >> $SCCACHE_ARCHIVE.sha256 -SHA_ARGS="--check --status" +SHA_ARGS=(--check --status) # Busybox sha256sum uses different flags if sha256sum --version 2>&1 | grep -q BusyBox; then - SHA_ARGS="-sc" + SHA_ARGS=(-sc) fi -sha256sum $SHA_ARGS $SCCACHE_ARCHIVE.sha256 +sha256sum "${SHA_ARGS[@]}" $SCCACHE_ARCHIVE.sha256 -if [ ! -d $PREFIX ]; then - mkdir -p $PREFIX +if [ ! -d "$PREFIX" ]; then + mkdir -p "$PREFIX" fi # Extract only the sccache binary into $PREFIX and ignore README and LICENSE. # --wildcards doesn't work on busybox. -tar -xzvf $SCCACHE_ARCHIVE --strip-component=1 --directory $PREFIX --exclude="sccache*/*E*E*" -chmod a+x $PREFIX/sccache +tar -xzvf $SCCACHE_ARCHIVE --strip-component=1 --directory "$PREFIX" --exclude="sccache*/*E*E*" +chmod a+x "${PREFIX}/sccache" if [ -n "${GITHUB_PATH}" ]; then - echo "$PREFIX" >> $GITHUB_PATH + echo "$PREFIX" >> "$GITHUB_PATH" # Add executable for windows as mingw workaround. - echo "SCCACHE_PATH=$PREFIX/sccache.exe" >> $GITHUB_ENV + echo "SCCACHE_PATH=$PREFIX/sccache.exe" >> "$GITHUB_ENV" fi