-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-48025: [C++][GLib] Replace instances where build path is being added to built artifacts #48026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
As far as I understand failures are unrelated. Examples:
I am unsure on what is the problem on C GLib & Ruby / AMD64 Ubuntu 22.04 GLib & Ruby but does not seem related: |
|
The "undefined method" error will be fixed soon in upstream: test-unit/test-unit#329 |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 534ef71. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
Rationale for this change
There are several places where we are adding the build path on our built artifacts. We should avoid that in order to improve reproducibility of our builds.
What changes are included in this PR?
General build system hygiene improvement redacting absolute paths from the compiler flags to improve build reproducibility and caching efficiency.
Update for mkenums from full
@filename@to@basename@as seen on their official documentation:Are these changes tested?
Validated locally that reprotest doesn't fail on
enumsanymore.CI and tests have run.
Are there any user-facing changes?
No