GH-48246: [C++][Parquet] Fix pre-1970 INT96 timestamps roundtrip #48247
+31
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
Contributor
Author
pitrou
changed the title
wgtmac
reviewed
Nov 25, 2025
github-actions
bot
added
awaiting committer review
HuaHuaY
force-pushed
the
fix_negative_timestamp
branch
from
373eb49 to
bfc5217
Compare
HuaHuaY
force-pushed
the
fix_negative_timestamp
branch
from
bfc5217 to
d3a266c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Parquet should return the same timestamps as written.
What changes are included in this PR?
ArrowTimestampToImpalaTimestampwill adjust the calculation based on whether the timestamp is negativeAre these changes tested?
Yes.
Are there any user-facing changes?
No.