Skip to content

Conversation

@thisisnic
Copy link
Member

@thisisnic thisisnic commented Nov 28, 2025

Rationale for this change

lint failures

What changes are included in this PR?

Fix them by changing function used

Are these changes tested?

Yes

Are there any user-facing changes?

Nope

@thisisnic thisisnic requested a review from jonkeane as a code owner November 28, 2025 13:11
@github-actions
Copy link

⚠️ GitHub issue #48283 has been automatically assigned in GitHub to PR creator.

@thisisnic thisisnic requested a review from raulcd November 28, 2025 14:13
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thisisnic

@raulcd raulcd merged commit 5aa7dd1 into apache:main Nov 28, 2025
10 checks passed
@raulcd raulcd removed the awaiting committer review Awaiting committer review label Nov 28, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Nov 28, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5aa7dd1.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants