From 134216de176a7a61bda09d342a3e942a39e0e09e Mon Sep 17 00:00:00 2001 From: akashorabek Date: Thu, 14 Jul 2022 19:38:05 +0600 Subject: [PATCH] reformat code for changed test assertness commit --- .../sdk/io/sparkreceiver/SparkReceiverIO.java | 6 +++--- .../io/sparkreceiver/SparkReceiverIOTest.java | 4 +--- .../WithOffsetTestOutputDoFn.java | 21 +++++++++---------- .../WithoutOffsetTestOutputDoFn.java | 2 +- 4 files changed, 15 insertions(+), 18 deletions(-) diff --git a/sdks/java/io/sparkreceiver/src/main/java/org/apache/beam/sdk/io/sparkreceiver/SparkReceiverIO.java b/sdks/java/io/sparkreceiver/src/main/java/org/apache/beam/sdk/io/sparkreceiver/SparkReceiverIO.java index 7a05d5e4a5851..5d771398920f8 100644 --- a/sdks/java/io/sparkreceiver/src/main/java/org/apache/beam/sdk/io/sparkreceiver/SparkReceiverIO.java +++ b/sdks/java/io/sparkreceiver/src/main/java/org/apache/beam/sdk/io/sparkreceiver/SparkReceiverIO.java @@ -36,8 +36,7 @@ /** Streaming sources for Spark {@link Receiver}. */ public class SparkReceiverIO { - private static final Logger LOG = - LoggerFactory.getLogger(SparkReceiverIO.class); + private static final Logger LOG = LoggerFactory.getLogger(SparkReceiverIO.class); public static Read read() { return new AutoValue_SparkReceiverIO_Read.Builder().build(); @@ -126,7 +125,8 @@ public PCollection expand(PBegin input) { sparkReceiverRead.getSparkReceiverBuilder(); checkStateNotNull(sparkReceiverBuilder, "withSparkReceiverBuilder() is required"); if (!HasOffset.class.isAssignableFrom(sparkReceiverBuilder.getSparkReceiverClass())) { - LOG.info("{} started reading", ReadFromSparkReceiverWithoutOffsetDoFn.class.getSimpleName()); + LOG.info( + "{} started reading", ReadFromSparkReceiverWithoutOffsetDoFn.class.getSimpleName()); return input .apply(Impulse.create()) .apply(ParDo.of(new ReadFromSparkReceiverWithoutOffsetDoFn<>(sparkReceiverRead))); diff --git a/sdks/java/io/sparkreceiver/src/test/java/org/apache/beam/sdk/io/sparkreceiver/SparkReceiverIOTest.java b/sdks/java/io/sparkreceiver/src/test/java/org/apache/beam/sdk/io/sparkreceiver/SparkReceiverIOTest.java index 837a07551d679..d8477a92e5280 100644 --- a/sdks/java/io/sparkreceiver/src/test/java/org/apache/beam/sdk/io/sparkreceiver/SparkReceiverIOTest.java +++ b/sdks/java/io/sparkreceiver/src/test/java/org/apache/beam/sdk/io/sparkreceiver/SparkReceiverIOTest.java @@ -21,6 +21,7 @@ import static org.junit.Assert.assertThrows; import static org.junit.Assert.assertTrue; +import java.util.List; import org.apache.beam.runners.direct.DirectOptions; import org.apache.beam.runners.direct.DirectRunner; import org.apache.beam.sdk.Pipeline; @@ -33,8 +34,6 @@ import org.junit.runner.RunWith; import org.junit.runners.JUnit4; -import java.util.List; - /** Test class for {@link SparkReceiverIO}. */ @RunWith(JUnit4.class) public class SparkReceiverIOTest { @@ -142,7 +141,6 @@ public void testReadFromCustomReceiverWithoutOffset() { .withSparkConsumer(new CustomSparkConsumer<>()) .withSparkReceiverBuilder(receiverBuilder); - WithoutOffsetTestOutputDoFn testDoFn = new WithoutOffsetTestOutputDoFn(); List storedRecords = CustomReceiverWithoutOffset.getStoredRecords(); List outputRecords = WithoutOffsetTestOutputDoFn.getRecords(); diff --git a/sdks/java/io/sparkreceiver/src/test/java/org/apache/beam/sdk/io/sparkreceiver/WithOffsetTestOutputDoFn.java b/sdks/java/io/sparkreceiver/src/test/java/org/apache/beam/sdk/io/sparkreceiver/WithOffsetTestOutputDoFn.java index dae254708d9be..06067f61c64f0 100644 --- a/sdks/java/io/sparkreceiver/src/test/java/org/apache/beam/sdk/io/sparkreceiver/WithOffsetTestOutputDoFn.java +++ b/sdks/java/io/sparkreceiver/src/test/java/org/apache/beam/sdk/io/sparkreceiver/WithOffsetTestOutputDoFn.java @@ -17,21 +17,20 @@ */ package org.apache.beam.sdk.io.sparkreceiver; -import org.apache.beam.sdk.transforms.DoFn; - import java.util.ArrayList; import java.util.List; +import org.apache.beam.sdk.transforms.DoFn; public class WithOffsetTestOutputDoFn extends DoFn { - private final static List records = new ArrayList<>(); + private static final List records = new ArrayList<>(); - @ProcessElement - public void processElement(@Element String input, DoFn.OutputReceiver output) { - records.add(input); - output.output(input); - } + @ProcessElement + public void processElement(@Element String input, DoFn.OutputReceiver output) { + records.add(input); + output.output(input); + } - public static List getRecords() { - return records; - } + public static List getRecords() { + return records; + } } diff --git a/sdks/java/io/sparkreceiver/src/test/java/org/apache/beam/sdk/io/sparkreceiver/WithoutOffsetTestOutputDoFn.java b/sdks/java/io/sparkreceiver/src/test/java/org/apache/beam/sdk/io/sparkreceiver/WithoutOffsetTestOutputDoFn.java index 00aab7ee67e3b..955c5fb1cee1b 100644 --- a/sdks/java/io/sparkreceiver/src/test/java/org/apache/beam/sdk/io/sparkreceiver/WithoutOffsetTestOutputDoFn.java +++ b/sdks/java/io/sparkreceiver/src/test/java/org/apache/beam/sdk/io/sparkreceiver/WithoutOffsetTestOutputDoFn.java @@ -22,7 +22,7 @@ import org.apache.beam.sdk.transforms.DoFn; public class WithoutOffsetTestOutputDoFn extends DoFn { - private final static List records = new ArrayList<>(); + private static final List records = new ArrayList<>(); @ProcessElement public void processElement(@Element String input, OutputReceiver output) {