-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use RemoveSafeDeltaCounterCell for PerWorker counters #29877
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @AnandInguva added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
assign to next reviewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, left a few comments
...worker/src/main/java/org/apache/beam/runners/dataflow/worker/RemoveSafeDeltaCounterCell.java
Outdated
Show resolved
Hide resolved
...worker/src/main/java/org/apache/beam/runners/dataflow/worker/RemoveSafeDeltaCounterCell.java
Show resolved
Hide resolved
...worker/src/main/java/org/apache/beam/runners/dataflow/worker/RemoveSafeDeltaCounterCell.java
Show resolved
Hide resolved
Java PreCommit failing test due to #28957 (comment) |
Dataflow Streaming harness's metrics container will store
per worker counters
in a newRemoveSafeDeltaCounterCell
.For the new
PerWorkerMetrics
we want to support dynamically creating metrics that may not live the lifetime of the job, therefore we need to implement garbage collection for stale metrics.E.g. We want to support BigQuery Metrics on a per-bigquery-table basis. If the pipeline uses dynamic destinations to write to 100 tables at 12:00 and at 15:00 is only writing to a few tables, the underlying MetricsContainer should not hold on to metrics for all 100 tables.
In
RemoveSafeDeltaCounterCell
metric updates and deletions are handled atomically - usingConcurrentHashMap::compute
andConcurrentHashMap::remove
respectively - ensuring safe garbage collection.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.