Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RemoveSafeDeltaCounterCell for PerWorker counters #29877

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

JayajP
Copy link
Contributor

@JayajP JayajP commented Dec 27, 2023

Dataflow Streaming harness's metrics container will store per worker counters in a new RemoveSafeDeltaCounterCell.

For the new PerWorkerMetrics we want to support dynamically creating metrics that may not live the lifetime of the job, therefore we need to implement garbage collection for stale metrics.

E.g. We want to support BigQuery Metrics on a per-bigquery-table basis. If the pipeline uses dynamic destinations to write to 100 tables at 12:00 and at 15:00 is only writing to a few tables, the underlying MetricsContainer should not hold on to metrics for all 100 tables.

InRemoveSafeDeltaCounterCell metric updates and deletions are handled atomically - using ConcurrentHashMap::compute and ConcurrentHashMap::remove respectively - ensuring safe garbage collection.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@AnandInguva
Copy link
Contributor

assign to next reviewer

@Abacn Abacn self-requested a review December 27, 2023 22:28
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left a few comments

@github-actions github-actions bot added java and removed java labels Dec 28, 2023
@github-actions github-actions bot added java and removed java labels Dec 28, 2023
@Abacn
Copy link
Contributor

Abacn commented Dec 28, 2023

Java PreCommit failing test due to #28957 (comment)

@Abacn Abacn merged commit 50daf7d into apache:master Dec 28, 2023
16 of 18 checks passed
@JayajP JayajP deleted the removesafecounter branch December 28, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants