Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade RocksDB default format_version to 5 #4479

Closed
lhotari opened this issue Aug 15, 2024 · 0 comments · Fixed by #4480
Closed

Upgrade RocksDB default format_version to 5 #4479

lhotari opened this issue Aug 15, 2024 · 0 comments · Fixed by #4480
Assignees

Comments

@lhotari
Copy link
Member

lhotari commented Aug 15, 2024

Certain performance optimizations in RocksDB are only available with newer format_versions. For example, this is mentioned in Rocksdb BlockBasedTable Format:

Note: format_version=5 (Since RocksDB 6.6) uses a faster and more accurate Bloom filter implementation for full and partitioned filters.

Set the default format_version to 5 in conf/entry_location_rocksdb.conf.default and conf/ledger_metadata_rocksdb.conf.default.
Set the default value for dbStorage_rocksDB_format_version in KeyValueStorageRocksDB.java to 5.

Currently format_version has been set to 2 in conf/entry_location_rocksdb.conf.default. format_version=2 is really old since and it won't use certain optimizations when that is specified. The setting is missing from conf/ledger_metadata_rocksdb.conf.default. This could cause downgrading issues between RocksDB 9+ and RocksDB 7 since RocksDB 9's default format_version is 6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant