Sql aggregator does not work in native mode. #2748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppalaga
reviewed
Jun 8, 2021
Contributor
ppalaga
left a comment
ppalaga
left a comment
There was a problem hiding this comment.
A am +1 on this, two minor comments inline.
Contributor
|
One more thing: could we please keep #2693 open so that we do not forget to revisit this once we get the serialization support from Quarkus? Also, it would be nice to add one or more comments in the code that would clearly mark this solution as a workaround for #2693 Well, I see that it is not possible to comment in json files; maybe we could add a README.adoc explaining the situation? |
Contributor
Author
|
If I move automatic registrations of serialization into core, it would be probably better to create a new issue to replace this workaround once serialization is supported in quarkus. README.adoc expaining the details would be nice, I agree. |
JiriOndrusek
force-pushed
the
sql-aggregator
branch
from
e977d01 to
018b7c4
Compare
JiriOndrusek
force-pushed
the
sql-aggregator
branch
3 times, most recently
from
f2a5c79 to
47ec399
Compare
JiriOndrusek
force-pushed
the
sql-aggregator
branch
from
47ec399 to
82ad037
Compare
aldettinger
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2693
fixes #2623
I'm not sure whether we want to pprovide solution for this issue, if it uses native configuration.