-
Notifications
You must be signed in to change notification settings - Fork 208
Use of serialization feature of Quakus (includes Sql and Nitrite) #2904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of serialization feature of Quakus (includes Sql and Nitrite) #2904
Conversation
Yeah, that's how I would have implemented it. Otherwise every extension that wants serialization support has to duplicate the required steps. I guess the registration of the basic Java types ideally belongs in Quarkus itself. |
|
I agree that basic stuff would be in quarkus - in the future. (I plan to create a PR there) Thanks for your response! |
9ec6d48 to
6b4ba97
Compare
|
oh this is really nice. btw we should really add a task to revisit DefaultExchangeHolder as it has been designed when serialization was cool but now it should be better to use json/avro/protobof |
923bc7a to
4d6de8c
Compare
+1 |
|
@JiriOndrusek please rebase on |
|
I'll rebase |
69cf846 to
4f1e7a8
Compare
ppalaga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks @JiriOndrusek! Some comments and questions inline.
.../src/main/java/org/apache/camel/quarkus/core/deployment/spi/CamelSerializationBuildItem.java
Outdated
Show resolved
Hide resolved
...roups/foundation/core/src/main/java/org/apache/camel/quarkus/core/MySerializationObject.java
Outdated
Show resolved
Hide resolved
|
Is there any work remaining on this one? It'd be good to get it merged ASAP as there's a few other things that depend on it. |
|
Please leave me about an hour to add changes pointed by @ppalaga |
0b9ce1b to
4f05564
Compare
|
@jamesnetherton All items are fixed. There is no more remaining work on this PR. |
4f05564 to
2151e0f
Compare
fixes #2755
fixes #2255
In his change I propose registration for serialization of several basic classes. But because this is not required by the most of the extensions, I suppose that creating a buildItem and based registration on it, would be better. @ppalaga @jamesnetherton WDYT?Another problem isBigInteger, which doesn't work - I have to find why.