Skip to content

[CASSANDRA-21040][trunk] Calculate once and cache the result of ModificationStatement#requiresRead as a perf optimization #4492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
netudima wants to merge 1 commit into from
+4 −1
Closed

[CASSANDRA-21040][trunk] Calculate once and cache the result of ModificationStatement#requiresRead as a perf optimization #4492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@ public abstract class ModificationStatement implements CQLStatement.SingleKeyspa

private final Operations operations;

private final boolean isReadRequired;

private final RegularAndStaticColumns updatedColumns;

protected final Conditions conditions;
Expand Down Expand Up @@ -262,6 +264,7 @@ else if (this.type.isDelete())
this.conditionColumns = conditionColumnsBuilder.build();
this.requiresRead = requiresReadBuilder.build();
this.functions = findAllFunctions();
this.isReadRequired = operations.requiresRead();
}

@Override
Expand Down Expand Up @@ -536,7 +539,7 @@ public boolean requiresRead()
// * Deleting list element by value
// * Performing addition on a StringType (i.e. concatenation, only supported for CAS operations)
// * Performing addition on a NumberType, again only supported for CAS operations.
return operations.requiresRead();
return isReadRequired;
}

private Map<DecoratedKey, Partition> readRequiredLists(Collection<ByteBuffer> partitionKeys,
Expand Down