Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: remove RECORD_AUDIO permission #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ath0mas
Copy link
Contributor

@ath0mas ath0mas commented Aug 22, 2023

Platforms affected

Android

Motivation and Context

Permissions RECORD_AUDIO is not requested at runtime and unnecessary.
Replace #211 to fix #209?

Description

See previous PR #211 and issue #209.
But contrary to both of them, stating that The external permissions are already handled by the cordova-plugin-file, which this plugin depends on., seems wrong now: cordova-plugin-file ^8.0.0 does not declare any permission at all inside its plugin.xml, so this plugin can still do it.

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek added this to the 6.0.0 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Android): Plugin declares unnecessary permissions
3 participants