-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop Node.js v4 support from AppVeyor #76
Conversation
Uh, this should get an issue in https://github.com/apache/cordova as a collection for all plugins. Then all the PRs can link to that issue, we can make sure all plugins were taken care of etc. Is this already based on something we did for another Cordova repo? (these CI configs should be pretty much copy/paste to all similar repos in the best case) |
We had apache/cordova#5, but just for tooling and platforms |
Yeah, go ahead and create a new one. It's worth to centralize these things, otherwise someone will have to go through all repos in the future and make sure the all use the same config. |
There we go: apache/cordova#72 |
Great. See my PR comments on https://github.com/apache/cordova-plugin-statusbar/pull/124/files before you continue please. |
this is a BREAKING CHANGE
fbf5021
to
0915928
Compare
@janpio - ready for review now |
CI passes again, see apache/cordova#72 (comment) - I've used the same matrix as in https://github.com/apache/cordova-paramedic. |
We have a passing state at paramedic, so now we'll see what happens with the first plugins. apache/cordova-plugin-inappbrowser#465 is the other first try to adapt the configuration from there. I think you missed the local test for your adaptation here. |
Indeed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes on travis.yml were replaced by #80 - please remove those from this PR so it can be merged. thanks.
Obsolete with #80 - whoops, AppVeyor is still relevant. |
Part of apache/cordova#72
Platforms affected
n/a - development
Motivation and Context
Drops EOL Node.js 4 from CI config. BREAKING CHANGE! :)
Description
see above.
Testing
TravisCI and Appveyor test results.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)