Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize substr() string function with ASCII fast path #12367

Closed
Tracked by #12306
2010YOUY01 opened this issue Sep 7, 2024 · 3 comments
Closed
Tracked by #12306

Optimize substr() string function with ASCII fast path #12367

2010YOUY01 opened this issue Sep 7, 2024 · 3 comments
Assignees
@2010YOUY01
Labels
enhancement New feature or request

Comments

@2010YOUY01
Copy link
Contributor

Is your feature request related to a problem or challenge?

Part of #12306

#12306 has introduced the rationale for ASCII fast path in detail

This optimization has already been implemented on char_length() string function and got some performance improvement.
(In PR #12356)

Describe the solution you'd like

Implement ASCII fast path for substr() function

Describe alternatives you've considered

No response

Additional context

No response
@2010YOUY01 2010YOUY01 added the enhancement New feature or request label Sep 7, 2024
@2010YOUY01
Copy link
Contributor Author

take

@2010YOUY01 2010YOUY01 mentioned this issue Sep 12, 2024
Open
6 tasks
@thinh2
Copy link
Contributor

thinh2 commented Sep 30, 2024

Hi @2010YOUY01, are you working on this issue?

@2010YOUY01
Copy link
Contributor Author

Hi @2010YOUY01, are you working on this issue?

Hi, I forget to update 😰
It's done via #12444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2010YOUY01 2010YOUY01

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@2010YOUY01 @thinh2