Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support LIKE with ESCAPE \ #13312

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Support LIKE with ESCAPE \ #13312

merged 2 commits into from
Nov 24, 2024

Conversation

findepi
Copy link
Member

@findepi findepi commented Nov 8, 2024

Other escape characters are currently not supported.

@findepi
Support LIKE with ESCAPE \
c2ccd0d 
Other escape characters are currently not supported.
@github-actions github-actions bot added physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt) labels Nov 8, 2024
alamb
alamb approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thanks @findepi

@alamb
Copy link
Contributor

alamb commented Nov 23, 2024

(this PR needs a cargo fmt it seems to get CI passing)

@alamb alamb merged commit b42cb8b into apache:main Nov 24, 2024
25 checks passed
@alamb
Copy link
Contributor

alamb commented Nov 24, 2024

Thanks again @findepi

@findepi findepi deleted the findepi/support-like-with-escape-3d34ad branch November 25, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@findepi @alamb