Skip to content

"Non Panic Task error" is not an internal error #15108

@alamb

Description

@alamb

Describe the bug

This code is marked as an internal error (meaning it should not happen unless there is a bug):

// This should only occur if the task is
// cancelled, which would only occur if
// the JoinSet were aborted, which in turn
// would imply that the receiver has been
// dropped and this code is not running
return Some(internal_err!("Non Panic Task error: {e}"));

However, we have clear evidence that it can happen when the tokio runtime is shutdown / cancelled in this ticket

To Reproduce

Expected behavior

I expect the error to be an "execution error" not an internal error (just switch the error type)

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions