Skip to content

Avoid re-implementing expression simplification in pruning.rs #16004

@xudong963

Description

@xudong963
          I think we should leave the and/or folding to a dedicated optimizer pass (IIRC that's "expression simplification") instead of re-implementing it here again. It's unnecessarily complex, potentially slow, requires more tests to write and maintain, and is a potential source of additional bugs.

Originally posted by @crepererum in #15995 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions