Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change SQL non-integer numeric literal type from Float64 to Decimal128 #3394

Open
Tracked by #3480
kmitchener opened this issue Sep 8, 2022 · 0 comments
Open
Tracked by #3480
Labels
enhancement New feature or request

Comments

@kmitchener
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)

Describe the solution you'd like
A clear and concise description of what you want to happen.

Per discussion on #166 , capturing for example 1.1 in the SQL literal as a Decimal results in accurate numbers, especially during expression simplification, where a Float can result in wrong data. Postgres also captures these literals as decimals.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant