Support timestamp and date arguments for range and generate_series table functions
#16552
+659
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
|
FYI @Abdullahsab3 perhaps you would be interested in reviewing this PR as well |
alamb
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
Thank you @simonvandel -- I went through this PR pretty carefully and I found it a joy to review. It was well structured, well commented, and well tested. 🏆 for sure
I have nothing to suggest
I actually ran a code coverage analysis here:
cargo llvm-cov --html test --test sqllogictests -- table_functionsAnd pretty much all the code is covered except for some argument error checking which I think is totally find.
| } | ||
|
|
||
| /// Trait for values that can be generated in a series | ||
| trait SeriesValue: fmt::Debug + Clone + Send + Sync + 'static { |
There was a problem hiding this comment.
Thanks @simonvandel Very nice PR. I too enjoyed going through it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The table functions
rangeandgenerate_seriesnow matches the functionality of the scalar functions of the same name.What changes are included in this PR?
SeriesValuewhich abstracts how different value-types are generatedSeriesValuefor integers and timestamps. The timestamp logic is also used for date generationAre these changes tested?
Yes, added more slt tests.
Are there any user-facing changes?
Yes,
rangeandgenerate_seriestable functions are now more powerful.